refactor(generator): split description into sumary and doc`
#5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update input types to replace `description` with `summary` and `doc` - update json converters for the emitter schema change - update test cases accordingly resolve Azure#4771
added 16 commits
November 22, 2024 09:46
# Conflicts: # package-lock.json # src/TypeSpec.Extension/Emitter.Csharp/package.json
archerzz
commented
Nov 26, 2024
| @@ -45,7 +45,7 @@ internal BooleanValue(ClientDiagnostics clientDiagnostics, HttpPipeline pipeline | |||
| _endpoint = endpoint; | |||
| } | |||
|
|
|||
| /// <summary> Get. </summary> | |||
| /// <summary> Get boolean value. </summary> | |||
There was a problem hiding this comment.
I think this is better.
archerzz
requested review from
m-nash,
lirenhe,
ArthurMa1978,
hallipr and
JoshLove-msft
as code owners
|
Regen preview: Azure/azure-sdk-for-net#47277 No code change actually |
ArcturusZhang
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
descriptionwithsummaryanddocresolve #4771
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?